add isValueExpectedForType to handle abstract types #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adampetro
requested changes
Oct 24, 2025
adampetro
reviewed
Oct 27, 2025
lopert
force-pushed
the
lopert.abstract-types
branch
from
f61f2b1 to
d5ba41c
Compare
adampetro
reviewed
Oct 28, 2025
adampetro
approved these changes
Oct 29, 2025
There was a problem hiding this comment.
There are a bunch of new tests with valid outputs, but should we have more with errors to know that we're properly validating and not accidentally skipping validating objects?
|
(oops, accidentally hit approve when I meant to comment) |
adampetro
reviewed
Oct 30, 2025
adampetro
approved these changes
Oct 30, 2025
lopert
force-pushed
the
lopert.abstract-types
branch
from
6e2bb1c to
84542dd
Compare
saga-dasgupta
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fixture input validator doesn't currently handle GraphQL abstract types where different items can be different concrete types.
In this PR, when a field is missing from a fixture, we use
typeInfo.getParentType()to determine the concrete type, and validate whether that field is actually expected based on the fixture value's__typename.